Manchester | 25-SDC-Nov | Geraldine Edwards | Sprint 5 | Prep Exercises #280

Geraldine-Edwards · 2025-12-04T17:28:23Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

This PR contains the exercises within each step of the Sprint 5 Prep section

Questions

Happy to receive all feedback - especially regarding refactoring. Thanks!

…e types'

…king with mypy'

…dule Tools/Sprint 5/Prep - step 2 'Type Checking with mypy'

…nd objects'

…ed refactorings'

…t formatting

…ents.txt for dependencies

…m counts

OracPrime

Generally good code, with a few bits that need tidying up in the context of "good version control practice" and a few bits where I got picky because I'd have had nothing to say if I didn't get picky. Also through in an optional stretch exercise for fun

OracPrime · 2025-12-29T16:10:24Z

prep-exercises/a_why_use_types.py

+# ------------------------
+# Q. What does double("22") return? Did it do what you expected? Why did it return the value it did?
+# A. I expected the result to be 44 through coercion, like JavaScript.
+#    It returned the string repeated i.e. 2222 because Python is a strongly typed language and doesn't use coercion


No, Python isn't a strongly typed language, it's "duck typed". However it is as you point out more sensible in how it behaves than javascript.

@OracPrime Thanks for the extra context here David :)
Every resource I went to said it was strongly typed! :D
I have done a bit more reading on the differences between dynamic, static, strong, and duck typing. For me, Python is strongly typed because it doesn’t automatically mix incompatible types like "22" + 2. Also it is dynamically typed, not statically typed, so variable types are checked at runtime and can change. I agree with you about it being duck typed though because even though it enforces type rules at runtime, it still lets objects work if the operation makes sense. :) (No wonder Python is popular!)

Static typing, duck typing, dynamic typing, .... and the madness which is javascript!

OracPrime · 2025-12-29T16:14:48Z

prep-exercises/article_test.py

+
+
+# from typing import List, Set
+def unique_count(nums: List[int]) -> int:


Not sure why you've got 3 versions of this function here?

@OracPrime Haha, yes it is a bit confusing at first glance but this was some exercises from an article (https://dev.to/tusharsadhwani/the-comprehensive-guide-to-mypy-561m) that we had to complete.

OracPrime · 2025-12-29T16:15:27Z

prep-exercises/article_test.py

+
+reveal_type(counts)  # The special magic reveal_type method - 
+# you should only use reveal_type to debug your code, and remove it when you're done debugging.
+


And if it's "remove it when you're done debugging" it should probably never be checked in to github except commented out

As before, everything in this file is from an article and we just had to work through the exercises to deepen understanding - its not any code/program that I have totally written myself. :D

OracPrime · 2025-12-29T16:16:43Z

prep-exercises/article_test.py

+print_favorite_color(me)
+
+
+def print_favorite_color(person: Dict[str, str]) -> None:  # added types to function definition


Again it's odd to have before and after methods both here and live. The second one will "win" so later code will call it, but maybe better to remove or comment out the before version

OracPrime · 2025-12-29T16:18:10Z

prep-exercises/article_test.py

+
+def print_favorite_color(person: Dict[str, str]) -> None:  # added types to function definition
+    fav_color = person.get('favorite-color')
+    reveal_type(fav_color)  # added this line here


Again, don't leave reveal_type in for anything checked in.

OracPrime · 2025-12-29T16:24:05Z

prep-exercises/b_type_checking.py

+# added integer type annotation and a return type of string for the output and renamed the function
+# parameter to avoid shadowing issue with variable name in the outer scope
+def format_pence_as_string(total_pence_amount: int) -> str:
+    if total_pence_amount < 100:


What happens if the account has a negative balance?

@OracPrime Good question! :)
For this exercise we had to add the type annotations and fix the obvious bugs, but as you suggested when I ran this with negative account balances (so that the totals equalled positive and negative numbers) it handled both scenarios correcttly as part of the calculation.

I may have missed something, but I surely if total_pence_amount is -150 then you want £-1.50 whereas it will return -150p ??? I haven't run it, I'm just reading it.

OracPrime · 2025-12-29T16:34:02Z

prep-exercises/f_generics.py

+
+imran = Person(name="Imran", children=[fatma, aisha])
+
+def print_family_tree(person: Person) -> None:


If you're bored over the break an need a stretch objective, extend this to cope with grandchildren and great-grandchildren :)

Good idea! I will look to doing this... :D

OracPrime · 2025-12-29T16:35:48Z

prep-exercises/h_enums.py

+        age = int(input("Please enter your age: "))
+        minimum_age = 18
+        if age < minimum_age: 
+            raise ValueError("Age must be 18 or over.")


Would be better to embed minimum_age into the error message, just in case it changes.

Oh yes, of course, avoiding the magic number scenario completely! :) I've amended this!

OracPrime · 2025-12-29T16:37:58Z

prep-exercises/h_enums.py

+    try:
+        name = (input("Please enter your first name: ")).strip()
+        if not name.isalpha():
+            raise ValueError("Name must contain only alphabetic characters.")


Tell that to Jean-Claude van Damme!

Oops! Yes you are absolutely right! I need to always be taking into account the edge cases! Thanks David!

OracPrime · 2025-12-29T16:40:51Z

prep-exercises/i_inheritance.py

+    def get_full_name(self) -> str:
+        suffix = ""
+        if len(self.previous_last_names) > 0:
+            suffix = f" (née {self.previous_last_names[0]})"


If we're being picky, you should do a gender check here. For example Muhammad Ali, né Cassius Clay. You can probably skip this though!

…. Embed minimum age variable into error message for accuracy

OracPrime

De'Wayne would probably object to your regex still, but I'm prepared to let that be his problem :)

OracPrime · 2026-01-02T22:11:40Z

prep-exercises/b_type_checking.py

+# added integer type annotation and a return type of string for the output and renamed the function
+# parameter to avoid shadowing issue with variable name in the outer scope
+def format_pence_as_string(total_pence_amount: int) -> str:
+    if total_pence_amount < 100:


I may have missed something, but I surely if total_pence_amount is -150 then you want £-1.50 whereas it will return -150p ??? I haven't run it, I'm just reading it.

Geraldine-Edwards added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 4, 2025

Geraldine-Edwards added 14 commits December 4, 2025 17:38

Complete exercises for Module Tools/Sprint 5/Prep - step 1 'Why we us…

d21625b

…e types'

Complete exercises for Module Tools/Sprint 5/Prep - step 2 'Type Chec…

ff67f81

…king with mypy'

Complete exercises forthe 'Comprehensive guide to mypy' article in Mo…

5e0ebd9

…dule Tools/Sprint 5/Prep - step 2 'Type Checking with mypy'

Complete exercises for Module Tools/Sprint 5/Prep - step 3 'Classes a…

093032b

…nd objects'

Complete exercises for Module Tools/Sprint 5/Prep - step 4 'Methods'

fd85eca

Complete exercises for Module Tools/Sprint 5/Prep - step 5 'Dataclasses'

1f27187

Complete exercises for Module Tools/Sprint 5/Prep - step 6 'Generics'

7d8d652

Complete exercises for Module Tools/Sprint 5/Prep - step 7 'Type-guid…

ec5c6ce

…ed refactorings'

Complete exercises for Module Tools/Sprint 5/Prep - step 8 'enums'

cd028dc

Complete exercises for Module Tools/Sprint 5/Prep - step 9 'Inheritance'

56e7745

Fix: shadwing issue in function parpameters

6dc57fd

Fix: enforce minimum age requirement in user prompt and improve outpu…

e367c1d

…t formatting

Fix: specify type for previous_last_names in Child class constructor

491e971

Fix: update .gitignore to include .venv and .mypy_cache; add requirem…

8aed46e

…ents.txt for dependencies

Geraldine-Edwards force-pushed the prep-exercises branch from 7c9bc88 to 8aed46e Compare December 4, 2025 17:39

Geraldine-Edwards added 4 commits December 4, 2025 17:42

Add requirements.txt to .gitignore

3840632

Fix: update .gitignore to include .mypy_cache and requirements.txt

630ba6f

Fix: improve user input handling and type hinting for operating syste…

1e06469

…m counts

Fix: remove unused Tuple import from h_enums.py

8063ab7

OracPrime added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Dec 29, 2025

OracPrime reviewed Dec 29, 2025

View reviewed changes

Fix: enhance user input validation for name using regular expressions…

5cc2330

…. Embed minimum age variable into error message for accuracy

Geraldine-Edwards added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 2, 2026

OracPrime approved these changes Jan 11, 2026

View reviewed changes

OracPrime removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 11, 2026

OracPrime added Reviewed Volunteer to add when completing a review with trainee action still to take. Complete Volunteer to add when work is complete and all review comments have been addressed. labels Jan 11, 2026



		# from typing import List, Set
		def unique_count(nums: List[int]) -> int:


		reveal_type(counts) # The special magic reveal_type method -
		# you should only use reveal_type to debug your code, and remove it when you're done debugging.

		print_favorite_color(me)


		def print_favorite_color(person: Dict[str, str]) -> None: # added types to function definition


		imran = Person(name="Imran", children=[fatma, aisha])

		def print_family_tree(person: Person) -> None:

Uh oh!

Manchester | 25-SDC-Nov | Geraldine Edwards | Sprint 5 | Prep Exercises #280

Are you sure you want to change the base?

Manchester | 25-SDC-Nov | Geraldine Edwards | Sprint 5 | Prep Exercises #280

Uh oh!

Conversation

Geraldine-Edwards commented Dec 4, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

OracPrime left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OracPrime left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants